Repository navigation
Conversation
RgbeInfo.decompress() stored in.read() results without checking for the end of the stream, so a truncated file decoded with 0xFF bytes, and did not check that a run fits in the scan line, so a long run threw ArrayIndexOutOfBoundsException. Throw an ImagingException in both cases. Assisted-By: Claude Code:claude-opus-5-5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes IMAGING-394.
RgbeInfo.decompress()checked for the end of the stream only at a run's count byte: a run's value and literal bytes were stored fromin.read()unchecked, so a truncated HDR decoded silently with 0xFF bytes, and a run longer than the rest of the scan line threwArrayIndexOutOfBoundsException. Both now throw anImagingException.RgbeParserTest.testTruncatedAndOverlongRunsdecodes a complete 4x1 image, the same image cut off inside its last run, and a scan line with an overlong run; it fails without the change. The RGBE tests andmvn -B -DskipTests -DskipITspass.This issue was found by an LLM-Enhanced Static Analysis Engine and verified manually. The patch and this description were prepared with AI assistance (Claude Code) and reviewed by me; the commit carries an
Assisted-By:trailer.